Introduce CapJitTypedExpression#1234
Conversation
|
Wonderful, thank you very much. |
zickgraf
force-pushed
the
CapJitTypedExpression
branch
from
7d92674 to
b365f5e
Compare
zickgraf
force-pushed
the
CapJitTypedExpression
branch
2 times, most recently
from
4485f6b to
521d432
Compare
|
@mohamed-barakat I have pushed an update. It documents that only literal functions and global variables pointing to a function are allowed as second argument of |
zickgraf
force-pushed
the
CapJitTypedExpression
branch
from
521d432 to
63fac5c
Compare
|
The force-push removes a superfluous new line and rebases onto master, so nothing really new. |
zickgraf
force-pushed
the
CapJitTypedExpression
branch
from
63fac5c to
24d3f93
Compare
zickgraf
force-pushed
the
CapJitTypedExpression
branch
3 times, most recently
from
058b77b to
1a3fca2
Compare
|
I now have a concrete application for this PR in the context of using CompilerForCAP as a proof assistant. @mohamed-barakat Is it okay for you if I merge this PR soon? It will probably require some adjustments at places where empty lists occur. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1234 +/- ##
==========================================
+ Coverage 80.90% 80.94% +0.03%
==========================================
Files 489 489
Lines 62511 62578 +67
==========================================
+ Hits 50577 50653 +76
+ Misses 11934 11925 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Very nice.
Yes, please wait until https://github.com/homalg-project/CategoricalTowers/actions/runs/7112784251 passes and the packages are released. |
zickgraf
force-pushed
the
CapJitTypedExpression
branch
3 times, most recently
from
7cf7649 to
e11ca11
Compare
zickgraf
force-pushed
the
CapJitTypedExpression
branch
from
e11ca11 to
af2ea35
Compare
2 participants
Fixes #1213.
@mohamed-barakat
CapJitTypedExpressionallows to attach a data type to any expression, in particular empty lists and functions which both cannot infer their data type without context information. See the application in AdditiveClosure for an example for how to use this. Of course we can also add convenience methods likeCapJitFunctionWithDomainDataTypeor similar later on.I want to make sure that this works in principle, so feel free to play around with this. Currently, lots of warnings about empty lists are displayed which can be ignored for now.